Spring 6 Upgrade #37
Merged
Spring 6 Upgrade #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buckett
commented
Aug 3, 2023
mitch30000
reviewed
Jan 12, 2024
maurercw
reviewed
Jun 27, 2024
We add our own implicit grant and then use that in the configuration. Internally we still have to use the autorization_code grant but to correct that we'd need to duplicate more Spring Security classes. This also contains some cleanups and fixes.
buckett
force-pushed
the
spring-6-upgrade
branch
from
ef1d7a4 to
a9c0c31
Compare
# Conflicts: # pom.xml # src/main/java/uk/ac/ox/ctl/lti13/Lti13Configurer.java # src/main/java/uk/ac/ox/ctl/lti13/security/oauth2/client/lti/web/OIDCInitiatingLoginRequestResolver.java # src/main/java/uk/ac/ox/ctl/lti13/security/oauth2/client/lti/web/OIDCInitiationRegistrationResolver.java # src/main/java/uk/ac/ox/ctl/lti13/security/oauth2/client/lti/web/PathOIDCInitiationRegistrationResolver.java
|
Thanks everyone for your work on this, I'll make some more updates (documentation) and then hopefully release a new version to the maven repositories shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.